Rubicon: Pass PBS host info to XAPI #3903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And1sS
force-pushed
the
rubicon/update-xapi-integration
branch
from
d7201c1
to
06f32e8
Compare
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
And1sS
commented
Sep 4, 2024
| if err != nil { | ||
| t.Fatal("Error extracting pbs_version") | ||
| } | ||
| assert.Equal(t, pbsVersion, "", "Unexpected pbs_version value") |
There was a problem hiding this comment.
Any ideas on how to actually test version?
In pbs Java we just mock it. But it seems like here nobody tests it.
I can set version.Ver to test value at the beginning of test and defer its reset, but it is a dirty hack.
There was a problem hiding this comment.
I'm not sure there is any value in adding any additional test logic here, nor do I see an easy way to fake it. The version is just a string and is populated during the build process. Checking that it is empty seems sufficient to me since it will predictably always be an empty string in your unit tests.
We already have test coverage for the version package including the Ver field in endpoints/version_test.go so we can feel confident that Ver is set correctly on startup assuming the build is triggered with the version as a parameter.
bsardo
approved these changes
Sep 19, 2024
przemkaczmarek
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from prebid/prebid-server-java#3377